Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataplex): add aspect_type resource #660

Closed
wants to merge 45 commits into from
Closed

feat(dataplex): add aspect_type resource #660

wants to merge 45 commits into from

Conversation

nilan3
Copy link
Contributor

@nilan3 nilan3 commented Nov 27, 2024

Description of your changes

Add resources for the following terraform resources:

  • google_dataplex_aspect_type

Fixes #

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/aspecttype.yaml"

--- PASS: kuttl (45.11s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (44.02s)
PASS
10:54:19 [ OK ] running automated tests
image

nilan3 and others added 30 commits November 27, 2024 11:13
@nilan3
configure dataplex aspect type
a9d4a1b 
Signed-off-by: nilan3 <[email protected]>
@nilan3
configure dataplex aspect type
2c8c25b 
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Update Upjet to v1.4.1-0.20241007154751-5cdf36996e4a
33e98d8 
This includes PR 441 which fixes scraping of Refs which contains lists. See upjet v1.4.1-0.20241007154751-5cdf36996e4a

Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Regenerated resources
f9b9b06 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Update examples
76db83e 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Backport api changes from v1beta2 to v1beta1
b60ddd4 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Fix changed example manifests
8f3d21a 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
feat(networkconnectivity): add Service Connection Policy support
270e84e 
This adds support for google_network_connectivity_service_connection_policy Terraform resource, see
https://registry.terraform.io/providers/hashicorp/google/5.39.1/docs/resources/network_connectivity_service_connection_policy

Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Correct required attribute region -> location
1c05015 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Fixed serviceconnectionpolicy example
53eff3c 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Fixed subnetworkRef name in example
61737f4 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Fmt
fe0ba39 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Remove redudant MarkAsRequired on location
29c6fad 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@renovate @nilan3
Update actions/setup-go digest to 41dfa10
46e8b3f 
Signed-off-by: nilan3 <[email protected]>
@renovate @nilan3
Update actions/checkout digest to 11bd719
34cba92 
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
feat(redis): add Redis Cluster support
d455bf1 
This adds support for google_redis_cluster Terraform resource, see
https://registry.terraform.io/providers/hashicorp/google/5.39.1/docs/resources/redis_cluster

Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Put all discovery endpoints in AdditionalConnectionDetails
24bdc44 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Increase timeout to 30 min
acaa4a5 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@bradkwadsworth-mw @nilan3
added reference for private endpoint subnetworks for gke cluster
b286e7a 
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
build: Update submodule to d315554
cee4301 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
golangci-lint: Migrated deprecated configs
1f00876 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
golangci-lint: Remove archived/deprecated interfacer linter
4cdda3a 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
golangci-lint: megacheck has been replaced with gosimple, staticcheck…
a6dc390 
…, and unused

Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@rickard-von-essen @nilan3
Dockerfile: Updated deprecated syntax for ENV
655f3ce 
Signed-off-by: Rickard von Essen <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@jeanduplessis @nilan3
Remove workflows no longer needed.
4430272 
Signed-off-by: Jean du Plessis <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Use standalone crddiff tool
45efb38 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@nilan3
update gitignore
504bedf 
Signed-off-by: nilan3 <[email protected]>
@nilan3
enable taxonomy & policy tag
3fc7f58 
Signed-off-by: nilan3 <[email protected]>
@nilan3
make reviewable
951fae1 
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Bump Terraform provider version to v5.44.2
8a763f6 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
turkenf and others added 15 commits November 27, 2024 11:19
@turkenf @nilan3
Run make generate
a864d45 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@mergenci @nilan3
Backport new fields in APIs.
3dd441b 
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@mergenci @nilan3
Run make generate.
d0c4dbd 
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@mergenci @nilan3
Backport omitempty tags in DNS RecordSet resource.
8b1eba0 
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@jeanduplessis @nilan3
Stop using deprecated upbound/official-provider-ci workflows
3e00577 
Signed-off-by: Jean du Plessis <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Set the go version compatible with the project version in workflows
15c01a8 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@erhancagirici @nilan3
add go.lint.analysiskey make target for caching linters
69e86bb 
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@jeanduplessis @nilan3
Stop using deprecated upbound/official-provider-ci workflows
b4e41e9 
Signed-off-by: Jean du Plessis <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@ulucinar @nilan3
Disable running the build tagger for linting.
cbfcbea 
- Make scripts/tag.sh executable

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@ulucinar @nilan3
Enable linter analysis cache build phase and run the build tagger bef…
c3bef04 
…ore linting

- Linting is now done in two phases: an initial analysis cache build phase,
  and then the actual linting phase, to decrease the memory footprint of
  linting.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@erhancagirici @nilan3
bump go version to 1.23
e2d462f 
Signed-off-by: Erhan Cagirici <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Configure dns ResponsePolicy resource and add an example
029899e 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Configure dns ResponsePolicyRule resource and add an example
0a10c8b 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@turkenf @nilan3
Configure certificatemanager TrustConfig resource and add an example
621af7a 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: nilan3 <[email protected]>
@nilan3
clean up examples
3912f68 
Signed-off-by: nilan3 <[email protected]>
@nilan3 nilan3 force-pushed the feature/dataplex_aspect_types branch from cd4793b to 3912f68 Compare November 27, 2024 11:21
@nilan3 nilan3 closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar will be requested when the pull request is marked ready for review ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin will be requested when the pull request is marked ready for review sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf will be requested when the pull request is marked ready for review turkenf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nilan3 @rickard-von-essen @turkenf @bradkwadsworth-mw @jeanduplessis @mergenci @erhancagirici @ulucinar