Skip to content

Conversation

ma-ble
Copy link
Contributor

@ma-ble ma-ble commented Aug 28, 2025

Description of your changes

This PR updates sigs.k8s.io/controller-runtime to version v0.22.0 and aligns related Kubernetes dependencies accordingly.

As part of this update, the Apply method was implemented for WrapperClient and MockClient to support the new Apply method added to the client.Client interface in controller-runtime v0.22.0.

controller-runtime: Add native SSA support

Need help with this checklist? See the cheat sheet.

@ma-ble ma-ble requested a review from a team as a code owner August 28, 2025 12:19
@ma-ble ma-ble requested a review from phisco August 28, 2025 12:19
@derbauer97
Copy link

Hey any updates on this? We really need this to update our providers to the latest controller-runtime :)

@negz
Copy link
Member

negz commented Sep 10, 2025

Thanks! It'd help if you could open a draft PR against crossplane/crossplane that uses this branch (go mod replace statement) and the updated controller-runtime. That'll give us a sense of how much work (if any) we'll need to do in crossplane/crossplane to pick up this change.

Other than that code changes here LGTM.

@markussiebert
Copy link

@negz Like so: crossplane/crossplane#6802

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Before I merge though - @erhancagirici, @sergenyalcin, any concerns from your POV as provider maintainers?

Copy link
Contributor

@erhancagirici erhancagirici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks OK from provider's perspective too. I'll double check by bumping it at upjet side, though it is not a blocker for this PR. If extra work is needed there, it can be done on its own pace.

@negz
Copy link
Member

negz commented Sep 18, 2025

crossplane/function-sdk-go#226 looks good to me so I think this is good to go.

Thanks for chipping in to test this complicated change everyone.

@negz negz merged commit df56d77 into crossplane:main Sep 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants