Required import to avoid no auth provider available

[salaboy]

When trying to run the template project with make run, you hit this issue

ERROR   controller-runtime.manager      Failed to get API Group-Resources       {"error": "no Auth Provider found for name \"gcp\""}

Related: hashicorp/terraform-provider-kubernetes-alpha#46

This import fixes the problem:

_ "k8s.io/client-go/plugin/pkg/client/auth"

Which makes kind of sense..

[jbw976]

Also found this related upstream client-go issue: https://github.com/kubernetes/client-go/issues/839

I'm not sure why we don't see this in core crossplane itself, I don't see it importing this same package in the main crossplane entry point: https://github.com/crossplane/crossplane/blob/master/cmd/crossplane/main.go

Or in providers like provider-aws: https://github.com/crossplane/provider-aws/blob/master/cmd/provider/main.go

Anyone have insight into why it's not needed there?

[hasheddan]

@jbw976 @salaboy this same behavior could happen with Crossplane or any of the providers, but it only happens when running out of cluster and requiring "auth helpers" from a given cloud provider. For instance, if I have a GKE cluster that gives me a kubeconfig that specified to use gcloud to authenticate, we will not behave properly. This is typically not the setting that Crossplane or the providers are run in, but it can be helpful for developing locally against a remote cluster. I am fairly indifferent to whether we add it here by default or not.

[jbw976]

Ah, thanks for that clarification @hasheddan, that helps me understand this scenario further. I agree that a typical provider wouldn't be executed in this type of setup, where it is running outside of its control plane that is hosted in a cloud provider.

In this template repo, I'd lean towards optimizing for the common scenario, given this comment, this comment and this PR, meaning I don't think this import is needed by default.

I don't think they're useful for most clients, and it has a pretty big dependency footprint.

What are your thoughts on including this @salaboy? Happy to hear your opinion too :)

[salaboy]

@jbw976 I think it makes a lot of sense to not include it in the code itself, as that is not needed there for the provider final version running inside a cluster. But it should be mentioned in the https://github.com/crossplane/provider-template/blob/master/README.md inside the Developing section.
A note saying that you need to add _ "k8s.io/client-go/plugin/pkg/client/auth" import and in which file is that recommend.. probably also mentioned that the import needs to be removed for production usage.

[negz]

Closing some very old PRs. :)