feat(bump): update upjet, and deps

[haarchri]

Description of your changes

implement latest changes from upjet
add management policies (crossplane/upjet#248)

Fixes #

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

[haarchri]

i use the following WorkspaceStore config:

		WorkspaceStore: terraform.NewWorkspaceStore(log, terraform.WithFeatures(featureFlags)),

and the e2e uptests green:

--- PASS: kuttl (37.35s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (36.42s)
PASS
20:05:14 [ OK ] running automated tests

if i use the following WorkspaceStore config:

		WorkspaceStore: terraform.NewWorkspaceStore(log, terraform.WithDisableInit(len(*nativeProviderPath) != 0), terraform.WithProcessReportInterval(*pollInterval), terraform.WithFeatures(featureFlags)),

i get the follwoing error in managedResource:

apiVersion: v1
items:
- apiVersion: null.template.upbound.io/v1alpha1
  kind: Resource
  metadata:
    annotations:
      upjet.upbound.io/test: "true"
    creationTimestamp: "2023-08-03T17:58:02Z"
    generation: 1
    name: example
    resourceVersion: "801"
    uid: 041f86b8-c9eb-4b2f-a4b5-b486828a7784
  spec:
    deletionPolicy: Delete
    forProvider:
      triggers:
        example-trigger: example-value
    managementPolicies:
    - '*'
    providerConfigRef:
      name: default
  status:
    atProvider: {}
    conditions:
    - lastTransitionTime: "2023-08-03T17:58:03Z"
      message: |-
        observe failed: cannot run refresh: refresh failed: Inconsistent dependency lock file: The following dependency selections recorded in the lock file are inconsistent with the current configuration:
          - provider registry.terraform.io/hashicorp/null: required by this configuration but no version is selected

        To make the initial dependency selections that will initialize the dependency lock file, run:
          terraform init
      reason: ReconcileError
      status: "False"
      type: Synced
kind: List
metadata:
  resourceVersion: ""

[lsviben]

i use the following WorkspaceStore config:

		WorkspaceStore: terraform.NewWorkspaceStore(log, terraform.WithFeatures(featureFlags)),

and the e2e uptests green:

--- PASS: kuttl (37.35s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (36.42s)
PASS
20:05:14 [ OK ] running automated tests

if i use the following WorkspaceStore config:

		WorkspaceStore: terraform.NewWorkspaceStore(log, terraform.WithDisableInit(len(*nativeProviderPath) != 0), terraform.WithProcessReportInterval(*pollInterval), terraform.WithFeatures(featureFlags)),

i get the follwoing error in managedResource:

apiVersion: v1
items:
- apiVersion: null.template.upbound.io/v1alpha1
  kind: Resource
  metadata:
    annotations:
      upjet.upbound.io/test: "true"
    creationTimestamp: "2023-08-03T17:58:02Z"
    generation: 1
    name: example
    resourceVersion: "801"
    uid: 041f86b8-c9eb-4b2f-a4b5-b486828a7784
  spec:
    deletionPolicy: Delete
    forProvider:
      triggers:
        example-trigger: example-value
    managementPolicies:
    - '*'
    providerConfigRef:
      name: default
  status:
    atProvider: {}
    conditions:
    - lastTransitionTime: "2023-08-03T17:58:03Z"
      message: |-
        observe failed: cannot run refresh: refresh failed: Inconsistent dependency lock file: The following dependency selections recorded in the lock file are inconsistent with the current configuration:
          - provider registry.terraform.io/hashicorp/null: required by this configuration but no version is selected

        To make the initial dependency selections that will initialize the dependency lock file, run:
          terraform init
      reason: ReconcileError
      status: "False"
      type: Synced
kind: List
metadata:
  resourceVersion: ""

Seems somehow connected with adding the terraform.WithDisableInit(len(*nativeProviderPath) != 0) but I am not that familiar with that feature. Maybe @ulucinar can shead some light on it?

[ulucinar]

Hi folks,
The template provider does not use the shared gRPC server and instead, relies on the Terraform CLI to manage the lifecycle of the native provider process. Thus, we cannot use terraform.WithDisableInit(true) with the template provider. This option causes the provider to skip running a terraform init during the workspace initialization, and hence the error observed by @haarchri. We can skip running a terraform init only with the shared gRPC implementation.

[haarchri]

so then everything is fine with this PR - can i get a review @ulucinar ;)

[ulucinar]

Hi @haarchri,
The sync interval has a rather specific meaning tied to the internals of the controller-runtime:
https://github.com/kubernetes-sigs/controller-runtime/blob/304027bcbe4b3f6d582180aec5759eb4db3f17fd/pkg/cache/cache.go#L146

So, I would personally prefer keeping the reference to the controller-runtime in the explanation. There's also a warning there:

Change this value only if you know what you are doing. Defaults to 10 hours if unset.

I remember us discussing the name of this parameter and I remember saying syncInterval is a better alternative than the syncPeriod. Looks like we have borrowed the name from the upstream configuration parameter we are overriding. I've also seen that the core Crossplane documents it in the way suggested in this PR.

Even though we do the renaming to be consistent in the ecosystem, I believe we had better continue mentioning the controller-runtime and warn users that this is rather an advanced parameter to tackle with:

Suggested change

	syncInterval = app.Flag("sync", "Sync interval controls how often all resources will be double checked for drift.").Short('s').Default("1h").Duration()
	syncInterval = app.Flag("sync", "Controller manager cache sync period such as 300ms, 1.5h, or 2h45m. Determines the minimum frequency at which watched resources are reconciled. Use with caution.").Short('s').Default("1h").Duration()