Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: add essTLSCertsPath to create ESSOptions to protect against panic seg… #71

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

smileisak
Copy link
Contributor

@smileisak smileisak commented Sep 24, 2024

Description of your changes

When activating --enable-external-secret-stores the controller will fails with this error:

2024-09-24T09:31:37Z	DEBUG	provider-ovh	Starting	{"sync-period": "1h0m0s", "poll-interval": "10m0s", "max-reconcile-rate": 10}
2024-09-24T09:31:37Z	INFO	provider-ovh	Alpha feature enabled	{"flag": "EnableAlphaExternalSecretStores"}
2024-09-24T09:31:37Z	INFO	provider-ovh	Beta feature enabled	{"flag": "EnableBetaManagementPolicies"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x16c1c20]

goroutine 1 [running]:
github.com/edixos/provider-ovh/internal/controller/additionalip/move.Setup({0x203f2a0, 0x400032f860}, {{{0x2021a30, 0x40002d55f0}, {0x2021a00, 0x40008001a8}, 0x8bb2c97000, 0xa, 0x40003ac660, 0x0}, ...})
	github.com/edixos/provider-ovh/internal/controller/additionalip/move/zz_controller.go:33 +0x260
github.com/edixos/provider-ovh/internal/controller.Setup({0x203f2a0, 0x400032f860}, {{{0x2021a30, 0x40002d55f0}, {0x2021a00, 0x40008001a8}, 0x8bb2c97000, 0xa, 0x40003ac660, 0x0}, ...})
	github.com/edixos/provider-ovh/internal/controller/zz_setup.go:193 +0x4ac
main.main()
	github.com/edixos/provider-ovh/cmd/provider/main.go:122 +0x1dfc

This is happening because of o.ESSOptions is nil when running the controller.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally with provider-ovh generated from this template.

Signed-off-by: Ismail KABOUBI <[email protected]>
@jeanduplessis jeanduplessis merged commit 791f73a into crossplane:main Oct 7, 2024
8 checks passed
@jeanduplessis
Copy link
Collaborator

Thank you for the fix @smileisak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants