Skip to content

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 4, 2025

No description provided.

@mmetc mmetc added this to the 1.7.1 milestone Sep 4, 2025
@mmetc mmetc added the kind/enhancement New feature or request label Sep 4, 2025
Copy link

github-actions bot commented Sep 4, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Sep 4, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 51.93798% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.50%. Comparing base (c572b53) to head (ad68e6e).

Files with missing lines Patch % Lines
pkg/acquisition/modules/kinesis/kinesis.go 35.71% 50 Missing and 4 partials ⚠️
pkg/acquisition/modules/s3/s3.go 80.48% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3846   +/-   ##
=======================================
  Coverage   61.50%   61.50%           
=======================================
  Files         407      409    +2     
  Lines       42014    42025   +11     
=======================================
+ Hits        25839    25846    +7     
- Misses      14045    14047    +2     
- Partials     2130     2132    +2     
Flag Coverage Δ
bats 45.65% <0.00%> (-0.01%) ⬇️
unit-linux 34.47% <51.93%> (+0.01%) ⬆️
unit-windows 24.44% <27.13%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as ready for review September 5, 2025 11:16
@mmetc mmetc marked this pull request as draft September 17, 2025 21:03
@mmetc mmetc marked this pull request as ready for review September 25, 2025 09:58
@mmetc mmetc requested a review from blotus September 25, 2025 11:10
@mmetc
Copy link
Contributor Author

mmetc commented Oct 3, 2025

After moving anon creds to the test build tag, CI reported an error with s.ctx being null, so I made a second attempt to remove ctx from the struct.

To do: review the usage of ctx vs cctx

we may eventually need to pass ctx to Configure* methods too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant