Skip to content

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 23, 2025

No description provided.

@mmetc mmetc added this to the 1.7.1 milestone Sep 23, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 45.45455% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.57%. Comparing base (2860dca) to head (be03c15).
⚠️ Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apic.go 40.98% 24 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3907      +/-   ##
==========================================
- Coverage   61.59%   61.57%   -0.02%     
==========================================
  Files         405      405              
  Lines       41789    41800      +11     
==========================================
- Hits        25738    25737       -1     
- Misses      13923    13935      +12     
  Partials     2128     2128              
Flag Coverage Δ
bats 45.82% <7.57%> (+<0.01%) ⬆️
unit-linux 34.43% <45.45%> (-0.01%) ⬇️
unit-windows 24.34% <45.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as draft September 24, 2025 08:18
@mmetc mmetc marked this pull request as ready for review September 24, 2025 08:33
@LaurenceJJones LaurenceJJones self-requested a review September 26, 2025 12:50
@mmetc mmetc requested a review from sabban October 3, 2025 08:19
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 757c323 into master Oct 3, 2025
21 of 22 checks passed
@mmetc mmetc deleted the defer-loop branch October 3, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants