Skip to content

Conversation

@isuruf
Copy link

@isuruf isuruf commented Jan 8, 2026

  • Remove clang-19 since we are not building the experimental jit
  • Remove ld_impl because we are not hacking the makefiles
  • Add site_packages_path
  • Make recipe.yaml identical with just the variant name difference
  • Add a generate.sh to generate recipe.yaml from default variant

@isuruf isuruf marked this pull request as draft January 8, 2026 21:09
@isuruf isuruf force-pushed the tsan branch 11 times, most recently from 9a4b234 to d810a1e Compare January 8, 2026 21:55
- Remove clang-19 since we are not building the experimental jit
- Remove ld_impl because we are not hacking the makefiles
- Add site_packages_path
- Make recipe.yaml identical with just the variant name difference
- Add a generate.sh to generate recipe.yaml from default variant
- Add a runtime requirement of libsanitizer for gcc
@ngoldbaum
Copy link

ngoldbaum commented Jan 8, 2026

Ping @lucascolley in case you're curious how Isuru sorted out the python_abi stuff.

if [[ "${name}" == *free-threading* ]]; then
tag="cp35t"
else
tag="cp35"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be cp315? Or was this choice on purpose?

@lucascolley
Copy link

nice :) and on the Pixi side we have progress towards being able to use a single recipe with pin_subpackage to handle the variants: prefix-dev/pixi#5103

@isuruf
Copy link
Author

isuruf commented Jan 8, 2026

Can we have one recipe and pass a variant using variants.yaml?

name: python_abi
version: ${{ version }}
build:
string: "0_cp315"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascolley I had to change this from 0_${{ abi_tag }} because pixi cannot handle this correctly. Pixi would expect a build string of 0_ and complaint that it found 0_cp315. Probably an issue with conda/outputs thing in pixi build.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds right, a bug report would be perfect

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascolley
Copy link

Can we have one recipe and pass a variant using variants.yaml?

That would indeed be more simple once the variant-sensitivity is added for Pixi workspace dependencies

@ngoldbaum
Copy link

The readme probably needs an update too: https://github.com/python/cpython/tree/main/Tools/pixi-packages#maintenance

@ngoldbaum
Copy link

@crusaderky when you’re able to come back to this, let us know if this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants