fix(settings): emit prefs-changed event from setShortcuts and resetSh…#252
Open
AnayDhawan wants to merge 1 commit into
Open
fix(settings): emit prefs-changed event from setShortcuts and resetSh…#252AnayDhawan wants to merge 1 commit into
AnayDhawan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setShortcutsandresetShortcutswrote to the store directly without callingwritePref, so they never emittedterax://prefs-changed. Every other preference setter useswritePrefwhich fires the event.Why
Without the event, shortcut changes made in the settings webview never propagate to the main window until restart.
How
Route both functions through
writePreflike all other setters.Testing
pnpm exec tsc --noEmitcleanonPreferencesChangealready mapsKEY_SHORTCUTS— listener side was correct, only the emit was missing