fix(terminal): restore clipboard shortcuts and suppress ask popup#263
Closed
viniraioli wants to merge 3 commits into
Closed
fix(terminal): restore clipboard shortcuts and suppress ask popup#263viniraioli wants to merge 3 commits into
viniraioli wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates terminal and app selection behavior by improving platform-specific keyboard handling and clipboard integration.
Changes:
- Add a custom xterm addon + shortcut handler to support terminal copy/paste behavior.
- Switch Ctrl+Backspace modifier detection to use platform constants instead of UA sniffing.
- Prevent the “Ask” popup from persisting when the active tab is not the editor.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/terminal/lib/rendererPool.ts | Adds terminal clipboard handling (paste addon + copy/paste shortcuts) and improves platform modifier detection. |
| src/app/App.tsx | Uses a ref for current tab kind to close the ask popup when not in the editor tab. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore standard clipboard behavior in terminal and coding-agent sessions, and prevent the Ask Agent selection popup from appearing outside editor tabs.
Why
Windows users currently lose Ctrl+V inside coding agents, and Ctrl+C sends SIGINT even when terminal text is selected. The Ask Agent popup also overlaps copy actions on terminal selections. Closes #240.
How
Testing
Screenshots / GIFs
N/A - behavior-only UI change.
Notes for reviewer
I did not run a full manual Windows smoke test in pnpm tauri dev; this is validated by typecheck and targeted code inspection against the issue #240 repro steps.