Skip to content

fix: handle shifted tab shortcut on Linux #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cleisonsantos wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −5
Draft

fix: handle shifted tab shortcut on Linux #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/modules/shortcuts/shortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,21 @@ export type Shortcut = {
defaultBindings: KeyBinding[];
};

function normalizeKey(key: string): string {
return key === "ISO_Left_Tab" ? "Tab" : key;
}

function eventKeyMatches(e: KeyboardEvent, bindingKey: string): boolean {
const eventKey = normalizeKey(e.key).toLowerCase();
const expectedKey = normalizeKey(bindingKey).toLowerCase();
if (expectedKey === "tab" && e.code === "Tab") return true;
return eventKey === expectedKey;
}

function eventShiftKey(e: KeyboardEvent): boolean {
return e.shiftKey || e.key === "ISO_Left_Tab";
}

export const SHORTCUTS: Shortcut[] = [
{
id: "settings.open",
Expand Down Expand Up @@ -182,19 +197,16 @@ export function matchBinding(
binding: KeyBinding,
id?: ShortcutId
): boolean {
const eventKey = e.key.toLowerCase();
const bindingKey = binding.key.toLowerCase();

// Special case for Jump to Tab 1-9
if (id === "tab.selectByIndex") {
if (!/^[1-9]$/.test(e.key)) return false;
} else if (eventKey !== bindingKey) {
} else if (!eventKeyMatches(e, binding.key)) {
return false;
}

return (
!!e.ctrlKey === !!binding.ctrl &&
!!e.shiftKey === !!binding.shift &&
eventShiftKey(e) === !!binding.shift &&
!!e.altKey === !!binding.alt &&
!!e.metaKey === !!binding.meta
);
Expand Down