fix(semver): use semver util to check version upgrades #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
tthvo
force-pushed
the
fix-semver-compare
branch
2 times, most recently
from
07550f2
to
6ecaf75
Compare
|
Test image available: |
andrewazores
approved these changes
Aug 11, 2023
|
rebase please |
aali309
approved these changes
Aug 11, 2023
Signed-off-by: Thuan Vo <[email protected]>
tthvo
force-pushed
the
fix-semver-compare
branch
from
6ecaf75
to
d1dfc64
Compare
|
Test image available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #971
Description of the change:
Use
semverpackage to reliably compare semantic versions.Motivation for the change:
Previously, using the trick
major * 100 + minor * 10 + patch, which will suffer incorrect behavior if the comparing between, for example,1.11.0and0.43.0.