Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added install guide Issue #1884 #2405

Closed
wants to merge 9 commits into from
Closed

Conversation

j0sh21
Copy link
Contributor

@j0sh21 j0sh21 commented Dec 26, 2023

Please don't hesitate to reach out to me for feedback or to share a Lightning Wallet LN URL.
I acquired information about this issue through https://nodesignal.space/spenden-bitcoin-bounties/

#1884

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for specter-desktop-docs ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/65a5001640334624631befb7
😎 Deploy Preview https://deploy-preview-2405--specter-desktop-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k9ert
Copy link
Contributor

k9ert commented Jan 12, 2024

Awesome work! I did some changes:

  • added a reference in the yaml-file so that it'll get visible in the left menu
  • adjusted the headings. We only want one h1 heading in each file. It determines the Menu title and the h2 level headings get submenu-items. See the preview

Very clear and precise language. I only have two remarks:

  • Why is the section "OS-Specific Apps for Specter Desktop" coming after the comparison/decision tree ? It should imho maybe even be the first option to discuss
  • the electrum connection is already here since version 2.0.0.

Can you correct those two things?

@j0sh21
Copy link
Contributor Author

j0sh21 commented Jan 12, 2024

Thank you!

The decision tree is designed to help users identify the most suitable installation method based on their technical skills and preferences. When writing I thought it was logical to first guide the user through a decision-making process before introducing OS-specific apps, which are more straightforward and user-friendly options.

Based on your remarks, I made the following corrections:

  • Repositioning the "OS-Specific Apps for Specter Desktop" Section.
  • Updating Information about Electrum Connection.

@k9ert
Copy link
Contributor

k9ert commented Jan 13, 2024

as discussed on twitter, the decision tree is a bit weirdly formatted and could profit from https://mermaid-js.github.io/

@j0sh21
Copy link
Contributor Author

j0sh21 commented Jan 13, 2024

Added the mermaid graph. Please have a look.

@k9ert
Copy link
Contributor

k9ert commented Jun 11, 2024

closing this PR as everything has been merged in the other PR already.

@k9ert k9ert closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants