Fix: make Crystal::EventLoop#remove(io) a class method #15282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is called from IO::FileDescriptor and Socket finalizers, which means they can be run from any thread during GC collections, yet calling an instance method means accessing the current event loop, which may have not been instantiated yet for the thread.
ysbaddaden
force-pushed
the
fix/event-loop-remove
branch
from
9e0efc2 to
31f39d7
Compare
ysbaddaden
added
kind:bug
The API won't change if we start having two potential event loop implementations in a single binary (e.g. io_uring with a fallback to epoll).
straight-shoota
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is called from
IO::FileDescriptorandSocketfinalizers, which means they can be run from any thread during GC collections, yet calling an instance method means accessing the current event loop, which may have not been instantiated yet for the thread.Only the polling event loops (epoll, kqueue) need this method, and they don't need an instance method to clean up the fd in the global arena. The other event loops don't need it.
This patch thus changes the instance method into a class method so there isn't any attempt to allocate in a GC finalizer.
Bonus: being a NOOP for other event loops, the call will be optimized away, while it previously always had to resolve the event loop instance; the polling event loops will also be able to directly cleanup.