Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM.version #15354

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jan 17, 2025

Adds a new public method LLVM.version which returns the runtime version of libllvm (via LLVMGetVersion if available)
And we use that method in the compiller for crystal --version and the Crystal::LLVM_VERSION constant.

ysbaddaden
ysbaddaden previously approved these changes Jan 17, 2025
@straight-shoota straight-shoota added this to the 1.16.0 milestone Jan 17, 2025
@straight-shoota
Copy link
Member Author

straight-shoota commented Jan 18, 2025

I realized that this should be two changes: One fixing the bug in the compiler CLI, the other adding a new method LLVM.version to extract this piece from the compiler code.
So I reverted the second commit and added a new PR for the compiler change: #15355. This one should go in after.

@straight-shoota straight-shoota marked this pull request as draft January 18, 2025 11:34
@straight-shoota straight-shoota marked this pull request as ready for review January 20, 2025 11:04
@straight-shoota straight-shoota removed this from the 1.16.0 milestone Jan 20, 2025
@straight-shoota straight-shoota added this to the 1.16.0 milestone Jan 20, 2025
@straight-shoota straight-shoota merged commit b103c28 into crystal-lang:master Jan 21, 2025
70 checks passed
@straight-shoota straight-shoota deleted the feat/llvm.version branch January 21, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants