Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SPDX license identifiers for license in shard.yml #641

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Use SPDX license identifiers for license in shard.yml #641

merged 7 commits into from
Dec 18, 2024

Conversation

leoheitmannruiz
Copy link
Contributor

I'd love to see #221 implemented. This is my go at it!

@leoheitmannruiz
Copy link
Contributor Author

Oh, and, out of curiosity: in what context is license_url used?

@leoheitmannruiz
Copy link
Contributor Author

leoheitmannruiz commented Sep 12, 2024 •
edited
Loading

I suppose, being super proper would entail accommodating SPDX license expressions.

crystal, for instance, is licensed Apache-2.0 WITH Swift-exception.

straight-shoota
straight-shoota approved these changes Sep 24, 2024
View reviewed changes
docs/shard.yml.adoc Outdated Show resolved Hide resolved
@leoheitmannruiz
Copy link
Contributor Author

leoheitmannruiz commented Sep 24, 2024 •
edited
Loading

Thanks for the feedback!

What do you think about allowing for SPDX license expressions?

Edit: It seems to me that without them, it may not be possible to describe the licensing of a shard accurately. Such as in the case of crystal.

@straight-shoota
Copy link
Member

Expressions sounds good 👍
We don't need to do any specific processing for this, though. This is primarily an informative field anyway.

@leoheitmannruiz
Copy link
Contributor Author

I'm really sorry for not getting back to you!

How's this?

What about these, now:

https://github.com/crystal-lang/shards/blob/master/src/spec.cr#L216-L224
https://github.com/crystal-lang/shards/blob/master/spec/unit/spec_spec.cr#L29-L37

@straight-shoota straight-shoota added this to the 0.19.0 milestone Dec 17, 2024
@straight-shoota straight-shoota changed the title Use SPDX license identifiers for license Use SPDX license identifiers for license in shard.yml Dec 18, 2024
@straight-shoota straight-shoota merged commit 34f1c21 into crystal-lang:master Dec 18, 2024
10 checks passed
@leoheitmannruiz
Copy link
Contributor Author

Thanks!

@straight-shoota
Copy link
Member

Thank you! 🙇

@leoheitmannruiz
Copy link
Contributor Author

I suppose #221 can be closed?

@straight-shoota straight-shoota linked an issue Dec 18, 2024 that may be closed by this pull request
Recommend the usage of SPDX license identifiers in the license field #221
Closed
@straight-shoota straight-shoota mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees
No one assigned
Labels
kind:docs
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

Recommend the usage of SPDX license identifiers in the license field
3 participants
@leoheitmannruiz @straight-shoota @ysbaddaden