-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add etherscan function to ignore/remove unused contracts #247
Open
rmi7
wants to merge
4
commits into
dev
Choose a base branch
from
fix-etherscan-multifile-ignore-unused-contracts
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of a deployed contract
rmi7
commented
Mar 17, 2022
root_file_path = None | ||
base_path = "" | ||
for file_path, file_ast in compilation_unit.asts.items(): | ||
if root_file_path is not None: # already found target contract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing this to !=
will make the mypy error go away. But then pylint will error saying it needs to be is not
..
0xalpharush
reviewed
Jan 6, 2023
Comment on lines
+420
to
+433
root_file_path = None | ||
base_path = "" | ||
for file_path, file_ast in compilation_unit.asts.items(): | ||
if root_file_path is not None: # already found target contract | ||
break | ||
for node in file_ast["nodes"]: | ||
if node["nodeType"] == "ContractDefinition" and node["name"] == root_contract_name: | ||
root_file_path = file_path | ||
base_path = file_path.replace(file_ast["absolutePath"], "") | ||
break | ||
|
||
if root_file_path is None: | ||
# we could not find a contract with that name in any of the files | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
root_file_path = None | |
base_path = "" | |
for file_path, file_ast in compilation_unit.asts.items(): | |
if root_file_path is not None: # already found target contract | |
break | |
for node in file_ast["nodes"]: | |
if node["nodeType"] == "ContractDefinition" and node["name"] == root_contract_name: | |
root_file_path = file_path | |
base_path = file_path.replace(file_ast["absolutePath"], "") | |
break | |
if root_file_path is None: | |
# we could not find a contract with that name in any of the files | |
return | |
root_file_path = None | |
found = False | |
base_path = "" | |
for file_path, file_ast in compilation_unit.asts.items(): | |
if found: # already found target contract | |
break | |
for node in file_ast["nodes"]: | |
if node["nodeType"] == "ContractDefinition" and node["name"] == root_contract_name: | |
root_file_path = file_path | |
found = True | |
base_path = file_path.replace(file_ast["absolutePath"], "") | |
break | |
if not found: | |
# we could not find a contract with that name in any of the files | |
return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #246