Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detectors for incorrect use of Oracle API #2289

Open
wants to merge 102 commits into
base: dev
Choose a base branch
from
Open

Add detectors for incorrect use of Oracle API #2289

wants to merge 102 commits into from

Commits on Nov 3, 2023

  1. Oracle module

    @talfao
    talfao committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    78c3ea2 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Before mapping

    @talfao
    talfao committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6c3da7c View commit details
    Browse the repository at this point in the history

  2. Change the approach

    @talfao
    talfao committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    86d7dd3 View commit details
    Browse the repository at this point in the history

  3. Change the approach

    @talfao
    talfao committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9f8f9ab View commit details
    Browse the repository at this point in the history

  4. Return just not checked vars

    @talfao
    talfao committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e8a8758 View commit details
    Browse the repository at this point in the history

  5. Creating check for updated at - not finished

    @talfao
    talfao committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    aadbd58 View commit details
    Browse the repository at this point in the history

  6. Add some documentation

    @talfao
    talfao committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ed029ed View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. add checking of internal calls

    @talfao
    talfao committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    33b1c1f View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Added basics of navive approach and now try to divide the files

    @talfao
    talfao committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    398f067 View commit details
    Browse the repository at this point in the history

  2. Divided to two files and started with naive_check

    @talfao
    talfao committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    bbe73f9 View commit details
    Browse the repository at this point in the history

  3. Reoder values based on the nodes mapping and check_price

    @talfao
    talfao committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    6fded76 View commit details
    Browse the repository at this point in the history

  4. Add text output for price and timestamp

    @talfao
    talfao committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    72eda7f View commit details
    Browse the repository at this point in the history

  5. Improve checks part for price

    @talfao
    talfao committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e964ba3 View commit details
    Browse the repository at this point in the history

  6. Naive check work, however i need to find a way how to represent not e… 

    …xisting values
    @talfao
    talfao committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e98f03e View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Slot0 simple check

    @talfao
    talfao committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c1532d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Before experimenting with unused impl detector

    @talfao
    talfao committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    509ebaf View commit details
    Browse the repository at this point in the history

  2. Found used order

    @talfao
    talfao committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    3f77626 View commit details
    Browse the repository at this point in the history

  3. Finding indexes of returned vars in oracle

    @talfao
    talfao committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    876860d View commit details
    Browse the repository at this point in the history

  4. Naive check should always work

    @talfao
    talfao committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5260262 View commit details
    Browse the repository at this point in the history

  5. Change output from detector of data validiy

    @talfao
    talfao committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ec5c69f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Add revert check

    @talfao
    talfao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c250443 View commit details
    Browse the repository at this point in the history

  2. Fix an issue if variable is not constant in price

    @talfao
    talfao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    227b0f7 View commit details
    Browse the repository at this point in the history

  3. Correct revert check

    @talfao
    talfao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b4c9b26 View commit details
    Browse the repository at this point in the history

  4. Rechange the output for mitigating duplicates of arrays

    @talfao
    talfao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    f584e6d View commit details
    Browse the repository at this point in the history

  5. Simple detection of sequencer

    @talfao
    talfao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    5d79f48 View commit details
    Browse the repository at this point in the history

  6. Solved ordering of writing to vars

    @talfao
    talfao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b9ffe01 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Add handler if the node is not var

    @talfao
    talfao committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    57df560 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. First testing

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d45d144 View commit details
    Browse the repository at this point in the history

  2. Some changes to test

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    8a26717 View commit details
    Browse the repository at this point in the history

  3. Comment roundID for now

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    9eecd91 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into oracle_testing

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    9641faa View commit details
    Browse the repository at this point in the history

  5. Add other test

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    fa79feb View commit details
    Browse the repository at this point in the history

  6. Fix some issue

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    f7fa45c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dev' into oracle_testing

    @talfao
    talfao committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    548df1c View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Before changing vars_in_conditions

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    583b0e3 View commit details
    Browse the repository at this point in the history

  2. Solved internal calls

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e1cb0d3 View commit details
    Browse the repository at this point in the history

  3. double internal problem solved

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a93e35b View commit details
    Browse the repository at this point in the history

  4. Add when not param

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2316cfb View commit details
    Browse the repository at this point in the history

  5. Add some tests

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    387d171 View commit details
    Browse the repository at this point in the history

  6. Sequencer

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7452b4d View commit details
    Browse the repository at this point in the history

  7. Change text

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    fe8e744 View commit details
    Browse the repository at this point in the history

  8. Add deprecated call check

    @talfao
    talfao committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    de39bed View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Add interface comparism to aggregatorV3Interface

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e6d6b1b View commit details
    Browse the repository at this point in the history

  2. Add some documentation

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8378204 View commit details
    Browse the repository at this point in the history

  3. Changes in texting sorting and formatting

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4a8c4a5 View commit details
    Browse the repository at this point in the history

  4. Changes in doc

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    594e25e View commit details
    Browse the repository at this point in the history

  5. Merge deprecated call detector 

    Deprecated calls
    @talfao
    talfao authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3d780a4 View commit details
    Browse the repository at this point in the history

  6. Merge oracle testing and deprecated calls to dev 

    Oracle testing
    @talfao
    talfao authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    80bb128 View commit details
    Browse the repository at this point in the history

  7. Sequencer documentation

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2e1da07 View commit details
    Browse the repository at this point in the history

  8. Formatting/Refactoring of sequencer file

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    028e28c View commit details
    Browse the repository at this point in the history

  9. Remove WIKI_EXPLOIT_SCENARIO from sequencer

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2926d28 View commit details
    Browse the repository at this point in the history

  10. Remove unused code, add some comments, formatting

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e18751a View commit details
    Browse the repository at this point in the history

  11. Formatting, comments, documentation

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a3b71dc View commit details
    Browse the repository at this point in the history

  12. Change naming in testing and snapshots based on changed comments

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    58b195f View commit details
    Browse the repository at this point in the history

  13. Renaming

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    716212a View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary comment

    @talfao
    talfao committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b3e798e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. First restruct problems

    @talfao
    talfao committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5713e8b View commit details
    Browse the repository at this point in the history

  2. Successfull restruct

    @talfao
    talfao committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    59236b6 View commit details
    Browse the repository at this point in the history

  3. Data valid works for chainlink after restruct

    @talfao
    talfao committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3d546f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Renamed for generalisation

    @talfao
    talfao committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c20d244 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Check return node

    @talfao
    talfao committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    70e36a2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request crytic#11 from talfao/portability_change 

    Create a classes for portability to other oracle providers
    @talfao
    talfao authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    145e036 View commit details
    Browse the repository at this point in the history

  3. Clear before PR

    @talfao
    talfao committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b434a75 View commit details
    Browse the repository at this point in the history

  4. Solve subscriptable type

    @talfao
    talfao committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    1780794 View commit details
    Browse the repository at this point in the history

  5. Uncomment test_ast_parsing.vy + remove unnecessary comment

    @talfao
    talfao committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    2399a7a View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. fix: resolve pylint errors 

    fix: resolve W0201

fix: pylint  R1702

fix: pylint R1702 + Refactor

fix: pylint errors
    @talfao
    talfao committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3e21e7f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev

    @talfao
    talfao authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d1ca556 View commit details
    Browse the repository at this point in the history

  3. Merge dev to investigate_out_of_return

    @talfao
    talfao committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ef3b8fa View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. feat: Support out of function check

    @talfao
    talfao committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    75712c5 View commit details
    Browse the repository at this point in the history

  2. update test data

    @talfao
    talfao committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    c71da94 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. First changes for cross contract interaction

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7244835 View commit details
    Browse the repository at this point in the history

  2. feat: cross contract capturing of nodes

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c206ab2 View commit details
    Browse the repository at this point in the history

  3. fix: Fix issues with messages

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7f49ad5 View commit details
    Browse the repository at this point in the history

  4. removing unused code

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    b52d755 View commit details
    Browse the repository at this point in the history

  5. fix: changes to checks based on new feature

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    28d456f View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1 from talfao/investigate_out_of_return 

    Feature: Cross-file detection of Oracle use
    @talfao
    talfao authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    dc67a70 View commit details
    Browse the repository at this point in the history

  7. fix: undefined varible

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c65e887 View commit details
    Browse the repository at this point in the history

  8. fix: array issue

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    165dccd View commit details
    Browse the repository at this point in the history

  9. feat: check for timestamp in var

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    fb5e650 View commit details
    Browse the repository at this point in the history

  10. feat: more information if the variabe is checked out of original func… 

    …tion
    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    9296bae View commit details
    Browse the repository at this point in the history

  11. fix: handle scenario when too many variations

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    0efcfce View commit details
    Browse the repository at this point in the history

  12. fix: use recommended methods

    @talfao
    talfao committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    0606169 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. fix: recursion error

    @talfao
    talfao committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7a3ced0 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. fix: sequencer check

    @talfao
    talfao committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    6454d6a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. fix: better solution for recursion error

    @talfao
    talfao committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dff5e50 View commit details
    Browse the repository at this point in the history

  2. feat: all done for merge

    @talfao
    talfao committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d6ac5cb View commit details
    Browse the repository at this point in the history

  3. feat: for the merge improved checks 

    Improve checks and detection
    @talfao
    talfao authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    de9505b View commit details
    Browse the repository at this point in the history

  4. fix: black issue

    @talfao
    talfao committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    19472cf View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from talfao/new_features_and_checks 

    New features and checks
    @talfao
    talfao authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    14f43d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. feat: interfaces detection

    @talfao
    talfao committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    81365ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev

    @talfao
    talfao authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    bcebfeb View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. fix: nodes_with_var attribute

    @talfao
    talfao committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    b4fb7c2 View commit details
    Browse the repository at this point in the history

  2. fix: DATA_DEPENDENCY error

    @talfao
    talfao committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    02e04dd View commit details
    Browse the repository at this point in the history

  3. fix: destination error

    @talfao
    talfao committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    1ebbe1b View commit details
    Browse the repository at this point in the history

  4. fix: another recursion error

    @talfao
    talfao committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    f2b3346 View commit details
    Browse the repository at this point in the history

  5. fix: recursion error, better design

    @talfao
    talfao committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    8b8a7bb View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'dev' into dev

    @talfao
    talfao authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    da1ad9c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'dev' into dev

    @talfao
    talfao authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b94963d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'dev' into dev

    @talfao
    talfao authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b746a01 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fixes_after_evaluation' into dev

    @talfao
    talfao committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    89b9711 View commit details
    Browse the repository at this point in the history

  3. fix: dead code, improvements from coderabit

    @talfao
    talfao committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    46b900c View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. fix: remove unused code

    @talfao
    talfao committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    73f0b31 View commit details
    Browse the repository at this point in the history