io/file-descriptors: Add testing suggestion for each task. #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mateistanuca1
force-pushed
the
lab9_final
branch
2 times, most recently
from
ffc8bdc to
f4122d6
Compare
Suggested students to test manually each task before using 'tests/checher.sh', for a better understanding of the concept. Signed-off-by: Matei Stanuca <[email protected]>
mateistanuca1
force-pushed
the
lab9_final
branch
from
f4122d6 to
f246fa6
Compare
teodutu
requested changes
Oct 11, 2025
There was a problem hiding this comment.
This file doesn't belong to this lab, it should be added to lab 11.
| Test PASSED (File copies are identical) | ||
| ``` | ||
|
|
||
| If possible, try to manually test your implementation. |
There was a problem hiding this comment.
Suggested change
| If possible, try to manually test your implementation. | |
| To test your implementation, navigate to the `mmap_cp/support/src` folder. | |
| Run `make` to compile the code and test it manually with files generated by you. | |
| When you think your code is correct, go to `mmap_cp/support/test` and run `checker.sh` to validate your solution. |
Reword the other task like this. "If possible" makes no one want to actually test manually.
There was a problem hiding this comment.
In addition, change the beginning of this file to instruct students to use the lab archive and add a lab9.md file with the download link. Find a model in this PR: #169.
|
And one more thing: do NOT create branches in the upstream repo! Use your fork. |
Closed
|
Superseded by #201. Why didn't you just continue with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested students to test manually each task before using 'tests/checher.sh', for a better understanding of the concept.
Prerequisite Checklist
Description of changes