Skip to content

Conversation

@andutu0
Copy link

@andutu0 andutu0 commented Oct 24, 2025

The vendetta.c file provided in the support directory was already solved, so i removed the solution and only left the comment and the return in the main function.

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make skels creates the whole support/ folder including vendetta.c, so please remove the folder altogether in this PR.

@teodutu teodutu added the student-contrib Fix or improvement made by a student label Oct 25, 2025
@iCMDdev
Copy link

iCMDdev commented Oct 29, 2025

LGTM🚀

@andutu0 andutu0 force-pushed the issue-200-fix-vendetta.c branch from a0ec52c to 29d7c0b Compare October 29, 2025 20:12
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the checkpatch test, your commits should have a description. I'll add it when squashing your commits into a single one, but keep this in mind for any future contributions.

@teodutu teodutu merged commit 1955630 into cs-pub-ro:main Nov 2, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

student-contrib Fix or improvement made by a student

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chapters/software-stack/libc/drills/tasks/libc/support : vendetta.c is already solved

3 participants