Further fixes and clarifications on the share fields - #249
Merged
Conversation
Member
|
Can you rebase on current develop? |
MahdiBaghbani
approved these changes
Aug 20, 2025
MahdiBaghbani
left a comment
MahdiBaghbani
left a comment
Member
There was a problem hiding this comment.
Richard has changed the resource to Resource in the I-D, but in the spec.yaml we are still using resource.
I've merged the current develop into this branch with small modification and change the one-off Resource to resource for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #244, I realized that the text describing the share fields had some residual references from past edits, which make no sense any longer. This is to fix them.