fix(store): encode nats-js-kv keys #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]> Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
kobergj
approved these changes
Sep 23, 2024
Merged
fschade
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode nats-js-kv keys. This got lost by a dependency bump.
complicated thing .... #4842 (comment) ... don't ask
in case someone has to dig in again:
nats-js-kv used to always encode the keys. we changed that upstream to make it configurable ... as a good citizen ... you know ... then we had to make ocis always encode the key ... which led to #4678 (comment)
so yea ... we always encode the key ...