Skip to content

Conversation

@spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Jun 3, 2025

Changed the Windows platform toolset specified in configure.cmake from "Visual Studio 2019 (v142)" to "Visual Studio 2022 (v143)". Unable to identify a specific version (previously, 14.29.16.11; toolset, compiler?), as was listed previously. The output of perfmap3.cse on Win32 changed slightly (an extra "Info" message is displayed.) This version passes the CI, but now my local Mac gives several 0/-0 diffs in perfmap.cse, compared to the CI (due to AppleClang 14 vs. 15?).

@spahrenk spahrenk self-assigned this Jun 3, 2025
@chipbarnaby
Copy link
Contributor

The specific version number(s) are needed we learned the hard way. I will try to figure out what we should use.

@spahrenk spahrenk requested a review from chipbarnaby June 3, 2025 22:26
@spahrenk spahrenk marked this pull request as draft June 3, 2025 22:26
@nealkruis
Copy link
Contributor

Here's the list of toolset versions: https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering

The latest SDK versions can be found here: https://en.wikipedia.org/wiki/Microsoft_Windows_SDK

Not sure which SDK version we should target. Not sure it matters?

@chipbarnaby
Copy link
Contributor

chipbarnaby commented Jun 6, 2025

On my system, the current toolset version is 14.44.35207. MSVC is 17.14.4.

With -T v143 in configure.cmake, CSE builds successfully and appears to use 14.44.32507.

If I change to -T v143,version=14.44.35207, I cmake will not configure --

CMake Error at D:/cse/builds/win32-msvc/CMakeFiles/CMakeTmp/CMakeLists.txt:4 (project):
  Generator

    Visual Studio 17 2022

  given toolset and version specification

    v143,version=14.44.35207

  contains an invalid version specification.

If I configure with just v143 and then set by hand the MSVC Toolset Version to 14.44.35207, CSE builds OK.

Google queries located various postings about MSVC bugs related to toolset selection. I did not yet fully understand whether those problems apply to our situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants