Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mstemplate #17

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Mstemplate #17

wants to merge 7 commits into from

Conversation

freiburgermsu
Copy link

Hello @cshenry !

Here are edits, error corrections, and comments for MSTemplate:

  1. unused imports, unused function parameters, and undefined functions are flagged
    
  2. variable definitions are consolidated and default values were added to the signature to reduce redundancy
    
  3. generic argument names -- e.g. o and x -- were elaborated for greater readability
    
  4. a comment to remove an unused class attribute was heeded
    
  5. set() operations -- e.g. .update() and .intersection() -- were leveraged for greater efficiency than loops
    
  6. lambda loops were replaced with faster and more concise list comprehension
    
  7. Error messages were clarified
    

Thank you so much :)
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant