Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New msmodelutl #18

Open
wants to merge 231 commits into
base: dev
Choose a base branch
from
Open

Conversation

freiburgermsu
Copy link

Hello @cshenry !

Here are some minor edits of MSModelUtls:

  1. unused import is flagged
    
  2. variable definitions are consolidated
    
  3. values() is used to simplify loops through dictionaries
    
  4. the exchange_list is developed through list comprehension
    
  5. generic variable names were clarified
    
  6. 1/0 boolean logic, not associated with KBase objects, is replaced with True/False
    
  7. arguments that match the default parameters were removed for redundancy
    
  8. items() simplified a for loop
    
  9. a maximum was determined via max() and list comprehension
    

Thank you :)
Andrew

freiburgermsu and others added 29 commits September 13, 2022 19:14
@freiburgermsu
Copy link
Author

I accidentally pulled my main branch into this branch, which consequently updated the PR with my entire repository of commits and changes. I resolved all of the merge conflicts, however, so accepting this PR will not conflict with any changes in your branch.

Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants