Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mseditorapi #19

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Mseditorapi #19

wants to merge 4 commits into from

Conversation

freiburgermsu
Copy link

Hello @cshenry !

Here are edits and error corrections for MSEditorAPI:

  1. unused arguments are flagged
    
  2. error messages were clarified
    
  3. the catch of an unrecognized cpd ID was relocated to the beginning of the edit_biomass_compound function to remove redundancy and prevent unnecessary computation
    
  4. items() is leveraged to greater efficiency
    
  5. inconsistent reaction directionality (from my internship last summer) is replaced with consistent "<" & "=" symbols
    
  6. default values were initially defined, instead of being defined in an else clause
    
  7. in-line Metabolite definition is employed
    
  8. my old prompts for correcting errors were removed for irrelevance
    
  9. the solicitation for the clean_ends function to leverage strip() was fulfilled
    
  10. list comprehension is employed
    
  11. redundancy in the conditionals of get_coef_and_group() are eliminated by moving the error catch to the else clause
    
  12. reactant is renamed to reagent since the function is used for both reactants and products, and thus the term reactant is a misnomer
    
  13. the conditonals for directionality is simplified to a linear if..elif..else sequence and with consistent directional symbols
    
  14. the erroneous construction of the reagents dictionary (variables in the old code) is corrected and consolidated
    

Thank you for your review :)
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant