Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gapfillpkg edits and corrections #6

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

freiburgermsu
Copy link

@freiburgermsu freiburgermsu commented Jun 29, 2022

Hello @cshenry !

Here are edits and error corrections to gapfillpkg, which reduced the line count by ~50. The changes include:

  1. unused imports and variables are flagged
  2. items() was leveraged to consolidate a loop
  3. an excessive intermediary variable was removed
  4. variable definitions were consolidated
  5. redundant !=None was removed since any non-None value will be interpreted as True
  6. new_reactions was added as a class attribute for user convenience and accessibility
  7. the undefined groups variable is corrected to m, which prevents a KeyError
  8. 1/0 boolean logic is replaced for the added/reversed parameters
  9. function calls are consolidated
  10. in-line or logic and list comprehension are implemented for greater efficiency and conciseness

I can clarify or adjust any edits at your request.

Thank you,
Andrew

cshenry pushed a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant