Gapfillhelper edits and error corrections #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @cshenry !
Here are edits and error corrections of
Gapfillinghelper
, with a summary of the changes:exceptions.py
script, which is apart of the recent commits to mainbuild_id()
test_reaction_additions_againt_limits
functions were unfinished, hence the inferred intention of the functions were complete (two functions with the same name may also not be able to be defined in Python).enumerate
is leveraged to simplify and expedite indexing a listpenalties
dictionary is replaced withgapfilling_penalties
, which is defined earlier in thebuild_model_extended_for_gapfilling
functionnext
is replaced withcontinue
to fulfill the intended result of proceeding to the next iterationrxn
is introduced for the repeated attribute call to improve the readability ofmdl_extend_model_index_for_gapfilling
items()
is leveraged to eliminate a nested loopobj_coef
increate_minimal_reaction_objective
are removedself
object call is added toconvert_cobra_compound_to_kbcompound
max()
and list comprehension succinctly determine a maximumKBaseFBAUtilities
inreplicate_model
is commented since the function does not exist and thus this would throw an exceptionid
as a function are replaced with calls toid
as an attributeI can elaborate or amend any edits at your request.
Thank you :)
Andrew