Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fbapkgs #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fbapkgs #8

wants to merge 5 commits into from

Conversation

freiburgermsu
Copy link

@freiburgermsu freiburgermsu commented Jul 3, 2022

Hello @cshenry !

Here are a collection of minor edits for the following FBA Packages:

ChangeOptPkg:

  1. unused imports are flagged
  2. unused function returns were not removed
  3. variable names as Python keywords were renamed
  4. a default assignment of fluxvar simplifies the code

DrainFluxPkg:

  1. unused imports were flagged and a missing package was imported
  2. erroneous self arguments were removed
  3. missing .model. objects were added when metabolites were called

ElementUptakePkg:

  1. items() was used for greater efficiency

KBaseMediaPkg:

  1. unused imports and potentially unuseful function calls were flagged
  2. negative values are prefixed directly to values

MetaboFBAPkg:

  1. unused imports were flagged
  2. 1/0 boolean logic is replaced for the added/reversed parameters
  3. an erroneous call to peaks was replaced with self.parameters["peaks"], since this is defined while peaks is not
  4. variable names as Python keywords were renamed

ObjConstPkg:

  1. redundant functions were combined

ProblemReplicationPkg:

  1. unused imports were flagged and necessary packages were imported
  2. variable names as Python keywords were renamed

ProteomeFittingPkg:

  1. unused imports were flagged
  2. unused function returns were removed
  3. a potentially useless for loop was flagged

SimpleThermoPkg:

  1. an unused import is flagged

TotalFluxPkg:

  1. unused imports were flagged
  2. line breaks are introduced to improve readability

I can elaborate changes at your request.

Thank you so much :)
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant