refactor parseEndpoint to accept pod names with '.' in it #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
Madhu-1,
nixpanic,
Rakshith-R and
yati1998
Madhu-1
reviewed
Sep 23, 2024
rewantsoni
force-pushed
the
endpoint
branch
2 times, most recently
from
f57df8d
to
25ce9ae
Compare
Madhu-1
reviewed
Sep 24, 2024
rewantsoni
force-pushed
the
endpoint
branch
from
25ce9ae
to
5133421
Compare
Madhu-1
approved these changes
Sep 24, 2024
nixpanic
approved these changes
Sep 24, 2024
|
@Mergifyio refresh |
|
@Mergifyio rebase |
✅ Pull request refreshed |
✅ Branch has been successfully rebased |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
@Mergifyio rebase |
kubernetes allows us to create pod with '.' in between, we should not limit parsing such endpoints Signed-off-by: Rewant Soni <[email protected]>
✅ Branch has been successfully rebased |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes allows us to create pod with '.' in between, we should not limit parsing such endpoints