rebase: use toolchain for 1.22.6 #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to build the dependency projects (Rook) with a lower version instead of the hard 1.22.6 requirement. |
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
nixpanic,
Rakshith-R and
yati1998
iPraveenParihar
approved these changes
Sep 24, 2024
nixpanic
approved these changes
Sep 24, 2024
we dont have downstream golang with version 1.22.6 and csi-addons needs 1.22.6 to build for that reason we can use the toolchain to enforce the soft dependency. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
use-toolchain
branch
from
ee092d3
to
058f702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we dont have downstream golang with version 1.22.6 and csi-addons needs 1.22.6 to build for that reason we can use the toolchain to enforce the soft dependency.