sanitize connection pool key pod name #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold for testing reclaim space |
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
Madhu-1,
nixpanic,
Rakshith-R and
yati1998
Madhu-1
previously approved these changes
Oct 1, 2024
Madhu-1
reviewed
Oct 1, 2024
Madhu-1
reviewed
Oct 1, 2024
internal/controller/replication.storage/volumereplication_controller.go
Outdated
Show resolved
Hide resolved
rewantsoni
force-pushed
the
fix
branch
2 times, most recently
from
72be5a0
to
c41ba28
Compare
|
Can you please include a description in the commits as well? You have a nice description in the PR, and having it in the 1st commit would add it to the history in the git repository. |
The csi-addons sidecar sanitizes the holder identity. The connection pool stores the mapping with key as the unsanitized name for csiaddonsnode, which leads to the failed to find the namespace where driver issue. To address this, we should sanitize the csiaddonsnode name before entering it into connection pool. Signed-off-by: Rewant Soni <[email protected]>
Signed-off-by: Rewant Soni <[email protected]>
Madhu-1
approved these changes
Oct 7, 2024
iPraveenParihar
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csi-addons sidecar sanitizes the holder identity. The connection pool stores the mapping with key as the unsanitized name for csiaddonsnode, which leads to the
failed to find the namespace where driverissue.To address this, we should sanitize the csiaddonsnode name before entering it into connection pool.