Skip to content

Conversation

@naasanov
Copy link
Collaborator

@naasanov naasanov commented Jan 6, 2026

We were having issues where there were lots of extra changes in PRs because of formatting and whitespace. Adding these formatting pre-commit hooks should make sure that any changes are automatically formatted without manual work by the developer.

Changes:

  • Added infra for pre-commit to container setup (installing pre-commit library in dockerfile and installing the actual hooks in post create script
  • Created pre-commit config
    • General formatting for files (whitespace, end of file new line, etc)
    • Ruff linting and formatting, including new linter rules (we'll see if we keep this in)
    • TS/JS/Prettier formatting

Closes #124

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Test Results Summary

302 tests  ±0   302 ✅ ±0   11s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a98956c. ± Comparison against base commit 21e9a86.

♻️ This comment has been updated with latest results.

Copy link
Collaborator Author

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT merge this in until the fixes for formatting and linter are applied. Wait until all other PRs are merged, then apply the changes in order to avoid annoying merge conflicts

@naasanov naasanov merged commit d9e740b into main Jan 8, 2026
2 checks passed
@naasanov naasanov deleted the nick/pre-commit branch January 8, 2026 19:25
@naasanov naasanov mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting Pre-Commit Hook

2 participants