Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint 16 support #59

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

carlosjeurissen
Copy link

@carlosjeurissen carlosjeurissen commented Jan 24, 2024

Resolves: #58

This PR adds support for Stylelint 16 and above.

Important: The changes are breaking for any Stylelint version below 16.

@carlosjeurissen
Copy link
Author

@lahmatiy let me know if you need anything.

@carlosjeurissen
Copy link
Author

Updated other dependencies as well. @lahmatiy is there anything holding back for a release?

@JasonWeill
Copy link

@lahmatiy This would allow for a stylelint upgrade in JupyterLab, which would unblock jupyterlab/jupyterlab#16062. Would it be possible to cut a new release with this change, please?

@carlosjeurissen
Copy link
Author

carlosjeurissen commented Mar 27, 2024

@JasonWeill For the time being you can use the following:
https://www.npmjs.com/package/@carlosjeurissen/stylelint-csstree-validator

Eventually I hope we can get this PR merged and continue in this repo.

@JasonWeill
Copy link

@lahmatiy Would you be able to take a look at this pull request? Asking because you're the most recent person to have committed changes to this repo, and this PR has been open for nearly a year.

@carlosjeurissen carlosjeurissen force-pushed the stylelint-16 branch 2 times, most recently from 85003bb to ee52d01 Compare March 6, 2025 10:54
@carlosjeurissen
Copy link
Author

Just updated the PR which addresses some additional issues in later stylelint 16 versions.

In addition, the fork has been updated accordingly:
https://www.npmjs.com/package/@carlosjeurissen/stylelint-csstree-validator

@lahmatiy please let me know what steps to take to get this merged. Feel free to add me as contributor on both github and npm so we can get this continued as a project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylelint 16 Support
2 participants