feat: use enhanced-resolve for node resolution #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves to using `enhanced-resolve` for resolving reporters in the CLI. Primarily because it is more up to date with the node resolution algorithm, but seems we dropped a few deep dependencies along the way too (which is good).
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to using
enhanced-resolvefor resolving reporters in the CLI. Primarily because it is more up to date with the node resolution algorithm, but seems we dropped a few deep dependencies along the way too (which is good).you can see it caught a bug in one of our fixtures (missing package exports) which node's own algorithm would disallow (and enhanced-resolve does too)
in future i feel like this should actually just use
import.meta.resolve(path, base). however, that signature is only available behind a flag in node. I did also make a branch using the ponyfill (import-meta-resolveon npm) instead of this but it will refuse to import a directory from our ESM sources (rightly so) so the tests failif you'd prefer that, i'd be happy to push the branch