writer-json-sarif: propagate the "imp" flag as level

If the "imp" flag is set on a finding, set the SARIF level to "error", which means "Important". Related: https://issues.redhat.com/browse/OSH-565 Closes: #173
csutils · Apr 23, 2024 · cd5d2e5 · cd5d2e5
1 parent f05aa13
commit cd5d2e5
Show file tree

Hide file tree

Showing 5 changed files with 114,363 additions and 2 deletions.
diff --git a/src/lib/writer-json-sarif.cc b/src/lib/writer-json-sarif.cc
@@ -338,8 +338,12 @@ void SarifTreeEncoder::appendDef(const Defect &def)
         // update tool for this rule
         d->ruleMap[ruleId].tool = def.tool;
 
-    // key event severity level
-    sarifEncodeLevel(&result, keyEvt.event);
+    if (0 < def.imp)
+        // if the "imp" flag is set, promote this finding to "Important"
+        result.emplace("level", "error");
+    else
+        // key event severity level
+        sarifEncodeLevel(&result, keyEvt.event);
 
     // key event location
     object loc;

diff --git a/tests/csgrep/0124-sarif-writer-imp-args.txt b/tests/csgrep/0124-sarif-writer-imp-args.txt
@@ -0,0 +1 @@
+--mode=sarif