Stay Logged in Checkbox #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xihai01
reviewed
Feb 12, 2025
xihai01
reviewed
Feb 12, 2025
|
Thanks for the work on this @JustinTan-1. Address @xihai01's comments, pull down the recent changes, then we'll approve and merge. In the future...
|
|
Alright, will do for next time. Addressed comments, let me know if anything else needs to be changed |
Nice, pull down the recent changes/update your fork's branch so the merge conflict goes away (Press the Sync fork button in github) |
Passing staySigned to AuthContext and rendering the modal if user decides to log in. Will only save to async storage if the user decides to stay Logged in.
|
@JustinTan-1 Also let me know whenever you've forked CASA and finished their Ruby on Rails setup process Next task is here, can answer questions once you're set. |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stay logged in Checkbox to authentication page
What was edited, added, and or created
Screenshot/Video 📷
RPReplay_Final1739384578.MP4