23-make-backend-routes-for-users #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctc-devops
commented
Nov 28, 2023
Co-authored-by: cherhchen <[email protected]>
michellelin1
requested changes
Dec 7, 2023
There was a problem hiding this comment.
good work and thanks for getting this in early! everything functionally works, but i left a few minor comments. once you resolve those comments and delete the users query file, i'll approve these changes. also, you don't need to make these changes anytime soon; just finish before winter quarter.
Co-authored-by: cherhchen <[email protected]>
cherhchen
requested review from
michellelin1,
h0ethan04 and
ThatMegamind
and removed request for
h0ethan04
michellelin1
approved these changes
Dec 18, 2023
michellelin1
added a commit
that referenced
this pull request
Jan 8, 2024
* created catalog table * AT - created the published schedule table * fixed enum name * removed brackets around exist conditionals * added create table users statement * added drop table if exists * updated drop table statement * Made CRUD SQL queries for Published Schedule Table * added catalog CRUD queries * Attempt to figure out ENV variable issue with workflows * fix typo * try moving env variables * Revert changes * Make CRUD SQL queries for Users Table (#25) * Added UPDATE and DELETE queries for user table * added Get, Get pending accounts, and Post * implemented changes from pr feedback --------- Co-authored-by: Sean Fong <[email protected]> Co-authored-by: Philip Jian <[email protected]> * fixed published schedule types * added connection to db * 23-make-backend-routes-for-users (#26) * Create a pull trequest for branch 23-make-backend-routes-for-users * Co-authored-by: cherhchen <[email protected]> * Finished backend routes Co-authored-by: cherhchen <[email protected]> * Refactor users.js for minor updates and delete users.sql Co-authored-by: cherhchen <[email protected]> --------- Co-authored-by: Ethan Ho <[email protected]> Co-authored-by: cherhchen <[email protected]> * Make backend routes for Catelog (#27) * created catalog.js, made progress * added :id to the router functions, changed delete query * Completed code for routes. Running into db.query is not a function error * Completed Routes for Catelog * removed comments, fixed yarn lock * removed console logs * fixed ? Co-authored-by: liannejl <[email protected]> --------- Co-authored-by: Alyssia Tan <[email protected]> Co-authored-by: liannejl <[email protected]> Co-authored-by: liannejl <[email protected]> * Set up the nodeMailer route and the transporter (#28) * nodeMailer.js setup * Added nodeMailer.js code and transporter.js that is called within nodeMailer * Updated package.json to include nodeMailer dependency, added endpoint for emailRouter in app.js, set cors credentials to true so it doesn't block req --------- Co-authored-by: subinqkim <[email protected]> * Make Backend Routes for Published Schedule (#29) * Modified GET queries with joins on catalog table * created publishSchedule.js file * Mounted published schedule route on app.js * Added GET and POST route controller functions for published schedule * put and delete, not yet complete * updated publishedSchedule.js * updated to use numeric syntax for sql queries * small fixes in ppublishedSchedule.js * pull request feedback * pull request feedback cont. * fixed misc bugs --------- Co-authored-by: Sean Fong <[email protected]> Co-authored-by: Philip Jian <[email protected]> Co-authored-by: michellelin1 <[email protected]> Co-authored-by: ThatMegamind <[email protected]> * Minor DB Updates (#32) * Create a pull trequest for branch 31-minor-db-updates * updated db model and queries --------- Co-authored-by: michellelin1 <[email protected]> --------- Co-authored-by: Kristen Yee <[email protected]> Co-authored-by: Alyssia Tan <[email protected]> Co-authored-by: Cheryl Chen <[email protected]> Co-authored-by: subinqkim <[email protected]> Co-authored-by: chloecheng8 <[email protected]> Co-authored-by: Andrew Lee <[email protected]> Co-authored-by: ThatMegamind <[email protected]> Co-authored-by: ctc-devops <[email protected]> Co-authored-by: Sean Fong <[email protected]> Co-authored-by: Philip Jian <[email protected]> Co-authored-by: Ethan Ho <[email protected]> Co-authored-by: cherhchen <[email protected]> Co-authored-by: liannejl <[email protected]> Co-authored-by: liannejl <[email protected]>
ThatMegamind
added a commit
that referenced
this pull request
Jan 23, 2024
* created catalog table * AT - created the published schedule table * fixed enum name * removed brackets around exist conditionals * added create table users statement * added drop table if exists * updated drop table statement * Made CRUD SQL queries for Published Schedule Table * added catalog CRUD queries * Attempt to figure out ENV variable issue with workflows * fix typo * try moving env variables * Revert changes * Make CRUD SQL queries for Users Table (#25) * Added UPDATE and DELETE queries for user table * added Get, Get pending accounts, and Post * implemented changes from pr feedback --------- Co-authored-by: Sean Fong <[email protected]> Co-authored-by: Philip Jian <[email protected]> * fixed published schedule types * added connection to db * 23-make-backend-routes-for-users (#26) * Create a pull trequest for branch 23-make-backend-routes-for-users * Co-authored-by: cherhchen <[email protected]> * Finished backend routes Co-authored-by: cherhchen <[email protected]> * Refactor users.js for minor updates and delete users.sql Co-authored-by: cherhchen <[email protected]> --------- Co-authored-by: Ethan Ho <[email protected]> Co-authored-by: cherhchen <[email protected]> * Make backend routes for Catelog (#27) * created catalog.js, made progress * added :id to the router functions, changed delete query * Completed code for routes. Running into db.query is not a function error * Completed Routes for Catelog * removed comments, fixed yarn lock * removed console logs * fixed ? Co-authored-by: liannejl <[email protected]> --------- Co-authored-by: Alyssia Tan <[email protected]> Co-authored-by: liannejl <[email protected]> Co-authored-by: liannejl <[email protected]> * Set up the nodeMailer route and the transporter (#28) * nodeMailer.js setup * Added nodeMailer.js code and transporter.js that is called within nodeMailer * Updated package.json to include nodeMailer dependency, added endpoint for emailRouter in app.js, set cors credentials to true so it doesn't block req --------- Co-authored-by: subinqkim <[email protected]> * Make Backend Routes for Published Schedule (#29) * Modified GET queries with joins on catalog table * created publishSchedule.js file * Mounted published schedule route on app.js * Added GET and POST route controller functions for published schedule * put and delete, not yet complete * updated publishedSchedule.js * updated to use numeric syntax for sql queries * small fixes in ppublishedSchedule.js * pull request feedback * pull request feedback cont. * fixed misc bugs --------- Co-authored-by: Sean Fong <[email protected]> Co-authored-by: Philip Jian <[email protected]> Co-authored-by: michellelin1 <[email protected]> Co-authored-by: ThatMegamind <[email protected]> * Minor DB Updates (#32) * Create a pull trequest for branch 31-minor-db-updates * updated db model and queries --------- Co-authored-by: michellelin1 <[email protected]> * Protected routes have token refresh method, all CRUD methods work with the user database and firebase console (#37) * protected routes have method to refresh token, all CRUD Methods work with the database and firebase console. * took out console logs * removed test code --------- Co-authored-by: subinqkim <[email protected]> Co-authored-by: michellelin1 <[email protected]> --------- Co-authored-by: Kristen Yee <[email protected]> Co-authored-by: Alyssia Tan <[email protected]> Co-authored-by: Cheryl Chen <[email protected]> Co-authored-by: subinqkim <[email protected]> Co-authored-by: chloecheng8 <[email protected]> Co-authored-by: Andrew Lee <[email protected]> Co-authored-by: ThatMegamind <[email protected]> Co-authored-by: ctc-devops <[email protected]> Co-authored-by: Sean Fong <[email protected]> Co-authored-by: Philip Jian <[email protected]> Co-authored-by: Ethan Ho <[email protected]> Co-authored-by: cherhchen <[email protected]> Co-authored-by: liannejl <[email protected]> Co-authored-by: liannejl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors:
What does this PR contain?
How did you test these changes?
Attach images (if applicable)
Closes #23