Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backend routes for Catelog #27

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Conversation

ctc-devops
Copy link
Contributor

Authors:

What does this PR contain?

How did you test these changes?

Attach images (if applicable)

Closes #20

routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
@ThatMegamind ThatMegamind linked an issue Dec 2, 2023 that may be closed by this pull request
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good to us! Just try to address the minor comments (and do them for all routes). Also, if you guys could remove the yarn.lock changes from your PR that would be great!

routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Show resolved Hide resolved
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us, approved!

@michellelin1 michellelin1 merged commit a2965f7 into dev Dec 18, 2023
3 checks passed
@michellelin1 michellelin1 deleted the 20-backend-route-catalog branch December 18, 2023 19:55
michellelin1 added a commit that referenced this pull request Jan 8, 2024
* created catalog table

* AT - created the published schedule table

* fixed enum name

* removed brackets around exist conditionals

* added create table users statement

* added drop table if exists

* updated drop table statement

* Made CRUD SQL queries for Published Schedule Table

* added catalog CRUD queries

* Attempt to figure out ENV variable issue with workflows

* fix typo

* try moving env variables

* Revert changes

* Make CRUD SQL queries for Users Table (#25)

* Added UPDATE and DELETE queries for user table

* added Get, Get pending accounts, and Post

* implemented changes from pr feedback

---------

Co-authored-by: Sean Fong <[email protected]>
Co-authored-by: Philip Jian <[email protected]>

* fixed published schedule types

* added connection to db

* 23-make-backend-routes-for-users (#26)

* Create a pull trequest for branch 23-make-backend-routes-for-users

* Co-authored-by: cherhchen <[email protected]>

* Finished backend routes

Co-authored-by: cherhchen <[email protected]>

* Refactor users.js for minor updates and delete users.sql

Co-authored-by: cherhchen <[email protected]>

---------

Co-authored-by: Ethan Ho <[email protected]>
Co-authored-by: cherhchen <[email protected]>

* Make backend routes for Catelog (#27)

* created catalog.js, made progress

* added :id to the router functions, changed delete query

* Completed code for routes. Running into db.query is not a function error

* Completed Routes for Catelog

* removed comments, fixed yarn lock

* removed console logs

* fixed ?

Co-authored-by: liannejl <[email protected]>

---------

Co-authored-by: Alyssia Tan <[email protected]>
Co-authored-by: liannejl <[email protected]>
Co-authored-by: liannejl <[email protected]>

* Set up the nodeMailer route and the transporter (#28)

* nodeMailer.js setup

* Added nodeMailer.js code and transporter.js that is called within nodeMailer

* Updated package.json to include nodeMailer dependency, added endpoint for emailRouter in app.js, set cors credentials to true so it doesn't block req

---------

Co-authored-by: subinqkim <[email protected]>

* Make Backend Routes for Published Schedule (#29)

* Modified GET queries with joins on catalog table

* created publishSchedule.js file

* Mounted published schedule route on app.js

* Added GET and POST route controller functions for published schedule

* put and delete, not yet complete

* updated publishedSchedule.js

* updated to use numeric syntax for sql queries

* small fixes in ppublishedSchedule.js

* pull request feedback

* pull request feedback cont.

* fixed misc bugs

---------

Co-authored-by: Sean Fong <[email protected]>
Co-authored-by: Philip Jian <[email protected]>
Co-authored-by: michellelin1 <[email protected]>
Co-authored-by: ThatMegamind <[email protected]>

* Minor DB Updates (#32)

* Create a pull trequest for branch 31-minor-db-updates

* updated db model and queries

---------

Co-authored-by: michellelin1 <[email protected]>

---------

Co-authored-by: Kristen Yee <[email protected]>
Co-authored-by: Alyssia Tan <[email protected]>
Co-authored-by: Cheryl Chen <[email protected]>
Co-authored-by: subinqkim <[email protected]>
Co-authored-by: chloecheng8 <[email protected]>
Co-authored-by: Andrew Lee <[email protected]>
Co-authored-by: ThatMegamind <[email protected]>
Co-authored-by: ctc-devops <[email protected]>
Co-authored-by: Sean Fong <[email protected]>
Co-authored-by: Philip Jian <[email protected]>
Co-authored-by: Ethan Ho <[email protected]>
Co-authored-by: cherhchen <[email protected]>
Co-authored-by: liannejl <[email protected]>
Co-authored-by: liannejl <[email protected]>
ThatMegamind added a commit that referenced this pull request Jan 23, 2024
* created catalog table

* AT - created the published schedule table

* fixed enum name

* removed brackets around exist conditionals

* added create table users statement

* added drop table if exists

* updated drop table statement

* Made CRUD SQL queries for Published Schedule Table

* added catalog CRUD queries

* Attempt to figure out ENV variable issue with workflows

* fix typo

* try moving env variables

* Revert changes

* Make CRUD SQL queries for Users Table (#25)

* Added UPDATE and DELETE queries for user table

* added Get, Get pending accounts, and Post

* implemented changes from pr feedback

---------

Co-authored-by: Sean Fong <[email protected]>
Co-authored-by: Philip Jian <[email protected]>

* fixed published schedule types

* added connection to db

* 23-make-backend-routes-for-users (#26)

* Create a pull trequest for branch 23-make-backend-routes-for-users

* Co-authored-by: cherhchen <[email protected]>

* Finished backend routes

Co-authored-by: cherhchen <[email protected]>

* Refactor users.js for minor updates and delete users.sql

Co-authored-by: cherhchen <[email protected]>

---------

Co-authored-by: Ethan Ho <[email protected]>
Co-authored-by: cherhchen <[email protected]>

* Make backend routes for Catelog (#27)

* created catalog.js, made progress

* added :id to the router functions, changed delete query

* Completed code for routes. Running into db.query is not a function error

* Completed Routes for Catelog

* removed comments, fixed yarn lock

* removed console logs

* fixed ?

Co-authored-by: liannejl <[email protected]>

---------

Co-authored-by: Alyssia Tan <[email protected]>
Co-authored-by: liannejl <[email protected]>
Co-authored-by: liannejl <[email protected]>

* Set up the nodeMailer route and the transporter (#28)

* nodeMailer.js setup

* Added nodeMailer.js code and transporter.js that is called within nodeMailer

* Updated package.json to include nodeMailer dependency, added endpoint for emailRouter in app.js, set cors credentials to true so it doesn't block req

---------

Co-authored-by: subinqkim <[email protected]>

* Make Backend Routes for Published Schedule (#29)

* Modified GET queries with joins on catalog table

* created publishSchedule.js file

* Mounted published schedule route on app.js

* Added GET and POST route controller functions for published schedule

* put and delete, not yet complete

* updated publishedSchedule.js

* updated to use numeric syntax for sql queries

* small fixes in ppublishedSchedule.js

* pull request feedback

* pull request feedback cont.

* fixed misc bugs

---------

Co-authored-by: Sean Fong <[email protected]>
Co-authored-by: Philip Jian <[email protected]>
Co-authored-by: michellelin1 <[email protected]>
Co-authored-by: ThatMegamind <[email protected]>

* Minor DB Updates (#32)

* Create a pull trequest for branch 31-minor-db-updates

* updated db model and queries

---------

Co-authored-by: michellelin1 <[email protected]>

* Protected routes have token refresh method, all CRUD methods work with the user database and firebase console (#37)

* protected routes have method to refresh token, all CRUD Methods work with the database and firebase console.

* took out console logs

* removed test code

---------

Co-authored-by: subinqkim <[email protected]>
Co-authored-by: michellelin1 <[email protected]>

---------

Co-authored-by: Kristen Yee <[email protected]>
Co-authored-by: Alyssia Tan <[email protected]>
Co-authored-by: Cheryl Chen <[email protected]>
Co-authored-by: subinqkim <[email protected]>
Co-authored-by: chloecheng8 <[email protected]>
Co-authored-by: Andrew Lee <[email protected]>
Co-authored-by: ThatMegamind <[email protected]>
Co-authored-by: ctc-devops <[email protected]>
Co-authored-by: Sean Fong <[email protected]>
Co-authored-by: Philip Jian <[email protected]>
Co-authored-by: Ethan Ho <[email protected]>
Co-authored-by: cherhchen <[email protected]>
Co-authored-by: liannejl <[email protected]>
Co-authored-by: liannejl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Backend Routes for Catalog
5 participants