Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PS routes for ordering of seasons and schema for User table #54

Merged
merged 2 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion common/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,26 @@ const keysToCamel = (data) => {
return data;
};

module.exports = { keysToCamel, isInteger, calculateYear };
const getSeasonFromMonthAndYear = (month, year) => {
if (month === 11) {
return `Winter ${year + 1}`;
}
if (month === 0 || month === 1) {
return `Winter ${year}`;
}
// spring
// march-may -> winter [year]
if (month >= 2 && month <= 4) {
return `Winter ${year}`;
}
// summer
// june-august -> summer [year]
if (month >= 5 && month <= 7) {
return `Summer ${year}`;
}
// fall
// september-november -> fall [year]
return `Fall ${year}`;
};

module.exports = { keysToCamel, isInteger, calculateYear, getSeasonFromMonthAndYear };
41 changes: 13 additions & 28 deletions routes/publishedSchedule.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const express = require('express');
const { db } = require('../server/db');
const { keysToCamel, calculateYear } = require('../common/utils');
const { keysToCamel, calculateYear, getSeasonFromMonthAndYear } = require('../common/utils');

const publishedScheduleRouter = express.Router();

Expand Down Expand Up @@ -96,30 +96,7 @@ publishedScheduleRouter.get('/all-seasons', async (req, res) => {
const formattedDate = new Date(date.event_date);
const year = formattedDate.getFullYear();
const month = formattedDate.getMonth();
// const day = formattedDate.getDate();

// winter
// december (11) -> winter [year + 1]
// january (0) - february (1) -> winter [year]
if (month === 11) {
return `Winter ${year + 1}`;
}
if (month === 0 || month === 1) {
return `Winter ${year}`;
}
// spring
// march-may -> winter [year]
if (month >= 2 && month <= 4) {
return `Winter ${year}`;
}
// summer
// june-august -> summer [year]
if (month >= 5 && month <= 7) {
return `Summer ${year}`;
}
// fall
// september-november -> fall [year]
return `Fall ${year}`;
return getSeasonFromMonthAndYear(month, year);
};

try {
Expand All @@ -130,12 +107,20 @@ publishedScheduleRouter.get('/all-seasons', async (req, res) => {
published_schedule AS PS, day AS D
WHERE
D.id = PS.day_id
ORDER BY
D.event_date DESC;
`,
);
const allSeasonsResult = allDatesResult.map((row) => {
return getSeason(row);
const allUniqueSeasonsResult = [];

// Get all unique seasons by order of season, from most recent to least
allDatesResult.forEach((row) => {
const season = getSeason(row);
if (!allUniqueSeasonsResult.includes(season)) {
allUniqueSeasonsResult.push(season);
}
});
const allUniqueSeasonsResult = [...new Set(allSeasonsResult)];

res.status(200).json(keysToCamel(allUniqueSeasonsResult));
} catch (err) {
res.status(500).send(err.message);
Expand Down
2 changes: 1 addition & 1 deletion server/schema/users.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CREATE TYPE account_type as ENUM ('superadmin', 'admin');
CREATE TYPE account_type as ENUM ('admin', 'student');

DROP TABLE IF EXISTS users;

Expand Down
Loading