Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Frontend Routes and renamed all "Register" items to "SignUp" #16

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

h0ethan04
Copy link
Contributor

Added frontend routes to App.jsx; created new pages for Playground, Published Schedule and Catalog.
Changed login path to '/login' from '/' and renamed all items and files from "Register" to "SignUp" to better fit design plans.
closes #13

@h0ethan04 h0ethan04 changed the title Completed Sprint task and renamed all "Register" items to "SignUp" Added Frontend Routes and renamed all "Register" items to "SignUp" Jan 17, 2024
@h0ethan04 h0ethan04 linked an issue Jan 17, 2024 that may be closed by this pull request
Copy link
Member

@michellelin1 michellelin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting your PR in early! Everything looks good, just a few minor changes: change the redirect path to /login and add back the / route for PublishedSchedule page (you can still leave /publishedSchedule for now). Once those are addressed, this PR should be good :)

src/App.jsx Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
ThatMegamind
ThatMegamind previously approved these changes Jan 21, 2024
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, looks good now!

Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us!

@ThatMegamind ThatMegamind merged commit dbdcda4 into dev Jan 22, 2024
2 of 3 checks passed
@ThatMegamind ThatMegamind deleted the 13-setup-frontend-routes branch January 22, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup frontend routes
4 participants