Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Catalog Page (Frontend) and Integrate w/ Backend #20

Merged
merged 9 commits into from
Jan 21, 2024

Conversation

ctc-devops
Copy link
Contributor

Authors:

What does this PR contain?

How did you test these changes?

Attach images (if applicable)

Closes #9

src/App.jsx Outdated
</Router>
</CookiesProvider>
</ChakraProvider>
<ChakraProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have been a prettier change on my end to fix the formatting; should I revert this?

@seancfong seancfong marked this pull request as draft January 21, 2024 03:24
@seancfong seancfong marked this pull request as ready for review January 21, 2024 04:01
@michellelin1 michellelin1 linked an issue Jan 21, 2024 that may be closed by this pull request
michellelin1
michellelin1 previously approved these changes Jan 21, 2024
Copy link
Member

@michellelin1 michellelin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just made a minor edit to follow how we normally make backend calls

Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed a merge conflict, looks good now!

@ThatMegamind ThatMegamind merged commit 6b17943 into dev Jan 21, 2024
2 of 3 checks passed
@ThatMegamind ThatMegamind deleted the 9-main-catalog-page-and-integrate-backend-dev branch January 21, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main Catalog Page (Frontend) and Integrate w/ Backend
5 participants