Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Notification Page Functionality (Frontend) #39

Merged

Conversation

ctc-devops
Copy link
Contributor

@ctc-devops ctc-devops commented Feb 18, 2024

Authors:

What does this PR contain?

  • Notifications are sorted and grouped by day
  • Approving an account removes the entry from the list & displays a toast.
  • Notification list displays newly-confirmed and newly-added events

How did you test these changes?

Attach images (if applicable)

  • The notification button and drawer will be placed in the layout navbar, so http://localhost:3000/notification-sandbox will temporarily have a working demo of the notification page.

  • Clicking the bell icon opens the drawer
    image

  • Multiple pending accounts notifications in the same day will be grouped into the same day. Event notifications in the same day are separated.
    image

  • Toast Notifications
    image
    image
    image
    image

Additional Notes

  • The Figma hi-fi suggests to group notifications by hour (instead of days) if they occur in the last 24 hours. A bit of work beyond the scope of this issue may be required.
  • The current user schema doesn't support full names so emails were only used instead.

Closes #36

@ThatMegamind ThatMegamind linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Matches the high fidelity design pretty well already

@ThatMegamind ThatMegamind merged commit beaf4f5 into dev Feb 20, 2024
2 of 3 checks passed
@ThatMegamind ThatMegamind deleted the 36-complete-notification-page-functionality-frontend branch February 20, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Notification Page Functionality (Frontend)
4 participants