42 published schedule match high fidelity #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctc-devops
reviewed
Feb 29, 2024
michellelin1
previously requested changes
Mar 1, 2024
| if (a.split(' ')[1] !== b.split(' ')[1]) { | ||
| return b.split(' ')[1] - a.split(' ')[1]; | ||
| } else { | ||
| // If years are equal, compare alphabetically |
There was a problem hiding this comment.
the drop down should be sorted in reverse chronological order but sorting it alphabetically results in fall coming before summer.
| ))) | ||
| } | ||
| {/* season dropdown menu */} | ||
| <Select |
There was a problem hiding this comment.
The text of the dropdown is a bit large. Michael and I think that you can create 2 separate elements: 1 large text to hold the season name and 1 "hidden" select where the options would display but the selected option would not. Let us know your thoughts on this workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buttons are not functional
closes #42