Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create event form for catalog #6

Merged
merged 8 commits into from
Jan 3, 2024
Merged

Create event form for catalog #6

merged 8 commits into from
Jan 3, 2024

Conversation

ctc-devops
Copy link
Contributor

Authors:

What does this PR contain?

How did you test these changes?

Attach images (if applicable)

Closes #4

@lanaramadan lanaramadan linked an issue Nov 30, 2023 that may be closed by this pull request
Create Event Form for Catalog #4
Closed
michellelin1
michellelin1 previously requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@michellelin1 michellelin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, everything works!! we just have a few minor changes so once those are fixed we'll approve this pr :)

src/components/CreateEventForm/CreateEventForm.jsx Outdated Show resolved Hide resolved
src/components/CreateEventForm/CreateEventForm.jsx Outdated Show resolved Hide resolved
src/components/CreateEventForm/CreateEventForm.jsx Outdated Show resolved Hide resolved
michellelin1
michellelin1 reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@michellelin1 michellelin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also make sure to push the package.json so others can install the dependencies when they run this

ThatMegamind
ThatMegamind approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us now! (please excuse the extra commits we were fixing some package.json issues)

@ThatMegamind ThatMegamind merged commit 0dc1274 into dev Jan 3, 2024
2 of 3 checks passed
@ThatMegamind ThatMegamind deleted the 4-create-event-form-for-catalog branch January 3, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatMegamind ThatMegamind ThatMegamind approved these changes

@michellelin1 michellelin1 Awaiting requested review from michellelin1

Assignees

@chloecheng8 chloecheng8

@lanaramadan lanaramadan

Labels
3 pts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Event Form for Catalog
5 participants
@ctc-devops @michellelin1 @ThatMegamind @chloecheng8 @lanaramadan