Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog Create Event Form Matching Design #66

Merged
merged 8 commits into from
Mar 24, 2024

Conversation

ctc-devops
Copy link
Contributor

Authors:

What does this PR contain?

How did you test these changes?

Attach images (if applicable)

Closes #59

@lanaramadan lanaramadan linked an issue Mar 21, 2024 that may be closed by this pull request
useEffect(() => {
if (defaults && defaults[0] !== '')
filter.setValue(defaults);
}, [])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has missing dependencies: 'defaults' and 'filter'. Either include them or remove the dependency array.

Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@ThatMegamind ThatMegamind merged commit c80db93 into dev Mar 24, 2024
4 checks passed
@ThatMegamind ThatMegamind deleted the 59-catalog-create-event-form-match-design branch March 24, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog Create Event Form [Match Design]
5 participants