Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Batch 3 Fixes #74

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Bug Batch 3 Fixes #74

merged 5 commits into from
Apr 16, 2024

Conversation

ctc-devops
Copy link
Contributor

@ctc-devops ctc-devops commented Apr 9, 2024

Tasks completed
  • Cancel and Finish Day combined into a single Save and Exit button
    image

  • Matched catalog delete event modal to design
    image

  • Fixed logo not showing up properly
    image

We found out it wasn't showing up because images used for deployed version needed to be in the public folder. To test this, we edited HTML in deployed version to use the vite image currently in public and that image works.

Additional bug fixes
  • Fixed additional bug in published schedule where on open it would initially select the latest season (like Spring 2025) and then after a second or two it would rerender to select the current season based on today's date.
Bugs found
  • Flow logic of creating a new day is flawed where you're able to create a day with no events. On the modal that shows up in published schedule when you press the plus button, pressing Add to Schedule will create that day in the database and then take you to the planner modal. However, if you close the modal by closing the tab, it will allow that day to have no events. And then you can't edit/delete that day because days with no events do not show up on the published schedule page.

  • Upon pressing plus button and adding a day, the planner modal will display the day before, but the edit day details will show the right day.
    image

  • Planner modal does not implement logic of preventing overlapping events or match design of showing the warning toast.
    image

  • Upon creating a new day that also creates another season, it does not rerender the published schedule page. The new season does not show up in the dropdown unless you refresh the page.

  • When adding event to day planner and immediately go to remove it, it behaves weirdly until you go and add another event.

Closes #73

@lanaramadan lanaramadan linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made some extra adjustments based on some clarifications from design. Will double check the logo once this is merged into dev!

@ThatMegamind ThatMegamind merged commit 8cd020e into dev Apr 16, 2024
2 checks passed
@ThatMegamind ThatMegamind deleted the 73-Bug-Batch-3 branch April 16, 2024 20:10
@ThatMegamind ThatMegamind restored the 73-Bug-Batch-3 branch April 16, 2024 20:14
@michellelin1 michellelin1 deleted the 73-Bug-Batch-3 branch May 22, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Batch 3
4 participants