-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
70 undo approve reject account request #84
Conversation
isClosable: true, | ||
}); | ||
} | ||
}, [approveAfterTimer, declineAfterTimer, removeNotificationBlock]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Hook useEffect has missing dependencies: 'idToRemove', 'notificationBlock.key', 'removeEntry', and 'toast'. Either include them or remove the dependency array. If 'removeEntry' changes too often, find the parent component that defines it and wrap that definition in useCallback.
// isClosable: true, | ||
// }); | ||
} | ||
}, [approveAfterTimer, declineAfterTimer, removeNotificationBlock]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Hook useEffect has missing dependencies: 'idToRemove', 'notificationBlock.key', and 'removeEntry'. Either include them or remove the dependency array. If 'removeEntry' changes too often, find the parent component that defines it and wrap that definition in useCallback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work here! I know it turned out to be more work than expected so we appreciate all the effort 🫡
not done yet!