Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 undo approve reject account request #84

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

kristenyee
Copy link
Contributor

not done yet!

@kristenyee kristenyee linked an issue Apr 17, 2024 that may be closed by this pull request
@kristenyee kristenyee changed the base branch from main to dev April 17, 2024 20:58
isClosable: true,
});
}
}, [approveAfterTimer, declineAfterTimer, removeNotificationBlock]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has missing dependencies: 'idToRemove', 'notificationBlock.key', 'removeEntry', and 'toast'. Either include them or remove the dependency array. If 'removeEntry' changes too often, find the parent component that defines it and wrap that definition in useCallback.

// isClosable: true,
// });
}
}, [approveAfterTimer, declineAfterTimer, removeNotificationBlock]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has missing dependencies: 'idToRemove', 'notificationBlock.key', and 'removeEntry'. Either include them or remove the dependency array. If 'removeEntry' changes too often, find the parent component that defines it and wrap that definition in useCallback.

Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work here! I know it turned out to be more work than expected so we appreciate all the effort 🫡

@ThatMegamind ThatMegamind merged commit 457301b into dev Apr 18, 2024
3 checks passed
@ThatMegamind ThatMegamind deleted the 70-undo-approve-reject-account-request branch April 18, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo approve/reject account request
3 participants