Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Errors + Event Field Terminology #89

Merged
merged 7 commits into from
May 1, 2024

Conversation

ctc-devops
Copy link
Contributor

@ctc-devops ctc-devops commented Apr 23, 2024

What does this PR contain?

  • Fixed the event terminology in the catalog + add events to the Published Schedule
  • Added more specific errors for auth flows
  • Renamed Reset Password to Create New Password for better clarity (since resetpassword is the page for sending the link)
  • Created a forgot password confirmation screen to match design
  • Created a create account confirmation screen to match design
  • Created a Verify Email confirmation screen because changing action link required us to make our own verify email page (looks exactly like account pending approval except it says Email Successfully Verified)

!!!! Once merged in, firestore authentication email template custom action url should be changed to
https://aiss.ctc-uci.com/emailAction

Login

image

image

Reset Password Note that we do not have the error message for if the email exists in the database due to Email Enumeration Protection.

image

Create New Password

image

image

image

We added a link has expired error message for the case when the user tries to use the same link after already using it to reset the password. Let us know if we should set up a meeting with design later to clarify this. There were changes/fixes to the design during our sprint and we only found out on Monday LOL so we weren't able to set up a meeting in time but if necessary we could meet to make sure it matches the design exactly.

image

Create New Account

image

image

Verify Email

image

Standardizing to Subject and Event Type

image

image

image

Closes #85

@lanaramadan lanaramadan linked an issue Apr 23, 2024 that may be closed by this pull request
@Philip-Jian Philip-Jian self-requested a review May 1, 2024 03:33
Copy link
Contributor

@Philip-Jian Philip-Jian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Michael and Michelle will update the firestore authentication email template custom action url.

@Philip-Jian Philip-Jian merged commit 831b37c into dev May 1, 2024
4 checks passed
@Philip-Jian Philip-Jian deleted the 85-login-errors-event-field-terminology branch May 1, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Errors + Event Field Terminology
5 participants