Cleaning comments, unused values and eslint ignores #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ThatMegamind <[email protected]> Co-authored-by: michellelin1 <[email protected]>
ctc-devops
reviewed
May 1, 2024
ctc-devops
reviewed
May 1, 2024
Comment on lines
+36
to
+53
| const renderSeasons = async () => { | ||
| const { data } = await NPOBackend.get('/published-schedule/all-seasons'); | ||
| if (data.indexOf(curSeason) == -1) { | ||
| data.unshift(curSeason); | ||
| } | ||
|
|
||
| if (selectedSeason === '') { | ||
| setSelectedSeason(curSeason); | ||
| const seasonOrder = ['Fall', 'Summer', 'Spring']; | ||
| data.sort((a, b) => { | ||
| // Compare years first | ||
| if (a.split(' ')[1] !== b.split(' ')[1]) { | ||
| return b.split(' ')[1] - a.split(' ')[1]; | ||
| } else { | ||
| return seasonOrder.indexOf(a.split(' ')[0]) - seasonOrder.indexOf(b.split(' ')[0]); | ||
| } | ||
| }); | ||
|
|
||
| const seasonOrder = ['Fall', 'Summer', 'Spring']; | ||
| data.sort((a, b) => { | ||
| // Compare years first | ||
| if (a.split(' ')[1] !== b.split(' ')[1]) { | ||
| return b.split(' ')[1] - a.split(' ')[1]; | ||
| } else { | ||
| return seasonOrder.indexOf(a.split(' ')[0]) - seasonOrder.indexOf(b.split(' ')[0]); | ||
| } | ||
| }); | ||
| setAllSeasons(data); | ||
| }; |
There was a problem hiding this comment.
The 'renderSeasons' function makes the dependencies of useEffect Hook (at line 67) change on every render. To fix this, wrap the definition of 'renderSeasons' in its own useCallback() Hook.
| setSelectedSeason(curSeason); | ||
| } | ||
| renderSeasons(); | ||
| }, []); |
There was a problem hiding this comment.
React Hook useEffect has missing dependencies: 'curSeason', 'renderSeasons', and 'selectedSeason'. Either include them or remove the dependency array.
ThatMegamind
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #92